-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Enable App Launch Profiling UI tests #3673
Conversation
GH-3665 didn't enable the app launch profiling tests because they were still disable in Xcode. This PR fixes that and also uses more accessibility identifiers in the profiling tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3673 +/- ##
=============================================
+ Coverage 89.274% 89.308% +0.034%
=============================================
Files 534 534
Lines 58981 58974 -7
Branches 21170 21167 -3
=============================================
+ Hits 52655 52669 +14
+ Misses 5290 5274 -16
+ Partials 1036 1031 -5 see 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
01a28a9 | 1200.78 ms | 1227.90 ms | 27.12 ms |
de46f06 | 1255.53 ms | 1268.44 ms | 12.91 ms |
89bc37d | 1240.76 ms | 1248.24 ms | 7.48 ms |
b066509 | 1246.14 ms | 1272.42 ms | 26.28 ms |
7fb7afb | 1235.00 ms | 1256.81 ms | 21.81 ms |
289c0b8 | 1245.63 ms | 1253.76 ms | 8.13 ms |
31208ed | 1258.36 ms | 1263.86 ms | 5.50 ms |
881a955 | 1221.63 ms | 1243.38 ms | 21.75 ms |
becc941 | 1221.90 ms | 1240.37 ms | 18.47 ms |
f576153 | 1217.17 ms | 1225.06 ms | 7.89 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
01a28a9 | 22.85 KiB | 405.39 KiB | 382.54 KiB |
de46f06 | 22.85 KiB | 414.74 KiB | 391.89 KiB |
89bc37d | 20.76 KiB | 401.53 KiB | 380.77 KiB |
b066509 | 22.84 KiB | 403.13 KiB | 380.29 KiB |
7fb7afb | 20.76 KiB | 419.69 KiB | 398.94 KiB |
289c0b8 | 22.85 KiB | 407.67 KiB | 384.82 KiB |
31208ed | 20.76 KiB | 435.26 KiB | 414.50 KiB |
881a955 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
becc941 | 21.58 KiB | 419.82 KiB | 398.24 KiB |
f576153 | 20.76 KiB | 425.77 KiB | 405.01 KiB |
Previous results on branch: test/enable-launch-profiling-tests
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ef3a2de | 1202.08 ms | 1217.96 ms | 15.88 ms |
272683c | 1227.00 ms | 1241.83 ms | 14.83 ms |
807e277 | 1227.20 ms | 1247.88 ms | 20.67 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ef3a2de | 21.58 KiB | 424.30 KiB | 402.72 KiB |
272683c | 21.58 KiB | 424.28 KiB | 402.70 KiB |
807e277 | 21.58 KiB | 424.28 KiB | 402.70 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @philipphofmann
GH-3665 didn't enable the app launch profiling tests because they were still disabled in Xcode. This PR fixes that and also uses more accessibility identifiers in the profiling tests.
#skip-changelog