Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable App Launch Profiling UI tests #3673

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

philipphofmann
Copy link
Member

GH-3665 didn't enable the app launch profiling tests because they were still disabled in Xcode. This PR fixes that and also uses more accessibility identifiers in the profiling tests.

#skip-changelog

GH-3665 didn't enable the app launch profiling tests because they were
still disable in Xcode. This PR fixes that and also uses more
accessibility identifiers in the profiling tests.
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c0e955) 89.274% compared to head (15d26cb) 89.308%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3673       +/-   ##
=============================================
+ Coverage   89.274%   89.308%   +0.034%     
=============================================
  Files          534       534               
  Lines        58981     58974        -7     
  Branches     21170     21167        -3     
=============================================
+ Hits         52655     52669       +14     
+ Misses        5290      5274       -16     
+ Partials      1036      1031        -5     

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0e955...15d26cb. Read the comment docs.

Copy link

github-actions bot commented Feb 20, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.26 ms 1256.22 ms 25.97 ms
Size 21.58 KiB 424.28 KiB 402.70 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
01a28a9 1200.78 ms 1227.90 ms 27.12 ms
de46f06 1255.53 ms 1268.44 ms 12.91 ms
89bc37d 1240.76 ms 1248.24 ms 7.48 ms
b066509 1246.14 ms 1272.42 ms 26.28 ms
7fb7afb 1235.00 ms 1256.81 ms 21.81 ms
289c0b8 1245.63 ms 1253.76 ms 8.13 ms
31208ed 1258.36 ms 1263.86 ms 5.50 ms
881a955 1221.63 ms 1243.38 ms 21.75 ms
becc941 1221.90 ms 1240.37 ms 18.47 ms
f576153 1217.17 ms 1225.06 ms 7.89 ms

App size

Revision Plain With Sentry Diff
01a28a9 22.85 KiB 405.39 KiB 382.54 KiB
de46f06 22.85 KiB 414.74 KiB 391.89 KiB
89bc37d 20.76 KiB 401.53 KiB 380.77 KiB
b066509 22.84 KiB 403.13 KiB 380.29 KiB
7fb7afb 20.76 KiB 419.69 KiB 398.94 KiB
289c0b8 22.85 KiB 407.67 KiB 384.82 KiB
31208ed 20.76 KiB 435.26 KiB 414.50 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB
becc941 21.58 KiB 419.82 KiB 398.24 KiB
f576153 20.76 KiB 425.77 KiB 405.01 KiB

Previous results on branch: test/enable-launch-profiling-tests

Startup times

Revision Plain With Sentry Diff
ef3a2de 1202.08 ms 1217.96 ms 15.88 ms
272683c 1227.00 ms 1241.83 ms 14.83 ms
807e277 1227.20 ms 1247.88 ms 20.67 ms

App size

Revision Plain With Sentry Diff
ef3a2de 21.58 KiB 424.30 KiB 402.72 KiB
272683c 21.58 KiB 424.28 KiB 402.70 KiB
807e277 21.58 KiB 424.28 KiB 402.70 KiB

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @philipphofmann

@philipphofmann philipphofmann merged commit cf3bc5b into main Feb 22, 2024
70 checks passed
@philipphofmann philipphofmann deleted the test/enable-launch-profiling-tests branch February 22, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants