Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable App Launch Profiling UI tests #3665

Merged
merged 24 commits into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
758ceb9
test: Fix failing UIViewController tests
philipphofmann Feb 20, 2024
0bf298a
ci: Increase SauceLabs Timeout
philipphofmann Feb 20, 2024
58648ca
ci: SauceLabs remove downloading junit artifacts
philipphofmann Feb 20, 2024
e86aa8d
test: Enable App Launch Profiling UI tests
philipphofmann Feb 20, 2024
2508de5
add samples path
philipphofmann Feb 20, 2024
f9dd5b4
try any iphone pro
philipphofmann Feb 20, 2024
556e977
ci: Run UI tests on GH actions
philipphofmann Feb 20, 2024
2e33c77
fix matrix
philipphofmann Feb 20, 2024
dec48ef
fix iOS 13
philipphofmann Feb 20, 2024
11342ae
Merge branch 'main' into test/enable-launch-profiling-tests
philipphofmann Feb 20, 2024
6f2d386
Merge branch 'ci/move-ui-tests-to-gh-simulators' into test/enable-lau…
philipphofmann Feb 20, 2024
4aa1c21
remove sauce config
philipphofmann Feb 20, 2024
1f193aa
remove sauce config
philipphofmann Feb 20, 2024
9a0c4fe
add decision log entry
philipphofmann Feb 20, 2024
6fa93fd
disable profiling test for now.
philipphofmann Feb 20, 2024
0f963d2
use xcode 15 for ios 16
philipphofmann Feb 20, 2024
492e460
fix ios 16
philipphofmann Feb 20, 2024
4fd1740
fix ios 16
philipphofmann Feb 20, 2024
0c53aad
Merge branch 'ci/move-ui-tests-to-gh-simulators' into test/enable-lau…
philipphofmann Feb 20, 2024
949fbe0
enable tests in Xcode again
philipphofmann Feb 20, 2024
a38b040
wipe data
philipphofmann Feb 20, 2024
7415ac6
Merge branch 'main' into test/enable-launch-tprofiling-tests
philipphofmann Feb 20, 2024
d4cde5c
remove retry
philipphofmann Feb 20, 2024
8ef656b
Merge branch 'main' into test/enable-launch-profiling-tests
philipphofmann Feb 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ui-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ jobs:

- name: Run Fastlane
run: fastlane ui_tests_ios_swift device:"${{matrix.device}}"
shell: sh

- name: Archiving Raw Test Logs
uses: actions/upload-artifact@v4
Expand Down
17 changes: 1 addition & 16 deletions Samples/iOS-Swift/iOS-SwiftUITests/ProfilingUITests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@ import XCTest
class ProfilingUITests: BaseUITest {
override var automaticallyLaunchAndTerminateApp: Bool { false }

// this will run before the non-async BaseUITest.setUp, so we can bail out before running any of the logic in there
override func setUp() async throws {
try await super.setUp()
try checkEnvironment()
}

func testProfiledAppLaunches() throws {
app.launchArguments.append("--io.sentry.wipe-data")
launchApp()
Expand Down Expand Up @@ -46,6 +40,7 @@ class ProfilingUITests: BaseUITest {
*/
func testProfilingGPUInfo() throws {
app.launchArguments.append("--disable-swizzling") // we're only interested in the manual transaction, the automatic stuff messes up how we try to retrieve the target profile info
app.launchArguments.append("--io.sentry.wipe-data")
launchApp()

goToTransactions()
Expand Down Expand Up @@ -73,16 +68,6 @@ class ProfilingUITests: BaseUITest {

@available(iOS 16, *)
extension ProfilingUITests {
// We don't need to test these on multiple OSes right now, and older versions seem to have issues; older devices or VM images running simulators might just be slower. Latest OS is enough coverage for our needs for now.
func checkEnvironment() throws {
#if !targetEnvironment(simulator)
throw XCTSkip("Currently doesn't work on SauceLabs.")
#endif

guard #available(iOS 16.0, *) else {
throw XCTSkip("iOS version too old for profiling test.")
}
}

enum Error: Swift.Error {
case missingFile
Expand Down
Loading