Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: SauceLabs remove downloading junit artifacts #3664

Merged
merged 3 commits into from
Feb 20, 2024
Merged

ci: SauceLabs remove downloading junit artifacts #3664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
758ceb9
test: Fix failing UIViewController tests
philipphofmann Feb 20, 2024
0bf298a
ci: Increase SauceLabs Timeout
philipphofmann Feb 20, 2024
58648ca
ci: SauceLabs remove downloading junit artifacts
philipphofmann Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .sauce/benchmarking-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ sauce:
concurrency: 4

defaults:
timeout: 20m
timeout: 60m

xcuitest:
app: ./DerivedData/Build/Products/Debug-iphoneos/iOS-Swift.app
Expand Down
9 changes: 1 addition & 8 deletions .sauce/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ sauce:
concurrency: 4

defaults:
timeout: 20m
timeout: 60m

xcuitest:
app: ./DerivedData/Build/Products/Test-iphoneos/iOS-Swift.app
Expand Down Expand Up @@ -34,10 +34,3 @@ suites:
devices:
- name: "iPhone.*"
platformVersion: "12"

artifacts:
download:
when: always
match:
- "*.junit.xml"
directory: ./artifacts/
10 changes: 7 additions & 3 deletions Sources/Sentry/SentryProfiler.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,15 +469,19 @@ + (nullable SentryEnvelopeItem *)createEnvelopeItemForProfilePayload:
}

if ([fm fileExistsAtPath:pathToWrite]) {
SENTRY_LOG_DEBUG(@"Already a%@ profile file present; make sure to remove them right after "
SENTRY_LOG_DEBUG(@"Already a %@ profile file present; make sure to remove them right after "
@"using them, and that tests clean state in between so there isn't "
@"leftover config producing one when it isn't expected.",
isTracingAppLaunch ? @" launch" : @"");
return;
}

SENTRY_LOG_DEBUG(@"Writing%@ profile to file.", isTracingAppLaunch ? @" launch" : @"");
SENTRY_CASSERT(
[data writeToFile:pathToWrite atomically:YES], @"Failed to write profile to test file");

NSError *error;
if (![data writeToFile:pathToWrite options:NSDataWritingAtomic error:&error]) {
SENTRY_LOG_ERROR(@"Failed to write data to path %@: %@", pathToWrite, error);
}
}
# endif // defined(TEST) || defined(TESTCI) || defined(DEBUG)

Expand Down
Loading