-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(launch profiling): debug logs and cleanup #3635
fix(launch profiling): debug logs and cleanup #3635
Conversation
…only used internally to this implementation
this somehow crept back in after a merge conflict
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4916322 | 1211.00 ms | 1220.00 ms | 9.00 ms |
b4dffe4 | 1205.65 ms | 1222.49 ms | 16.84 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4916322 | 21.58 KiB | 422.53 KiB | 400.95 KiB |
b4dffe4 | 21.58 KiB | 422.53 KiB | 400.95 KiB |
UI test |
…and do the overwrite
Two unit tests failing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Samples/iOS-Swift/PerformanceBenchmarks/SentrySDKPerformanceBenchmarkTests.m
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…o armcknight/feat/launch-profiling5-cleanup
…o armcknight/feat/launch-profiling5-cleanup
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## armcknight/feat/launch-profiling4-end-to-end-check #3635 +/- ##
========================================================================================
- Coverage 89.189% 89.167% -0.022%
========================================================================================
Files 532 532
Lines 58672 58659 -13
Branches 21044 21046 +2
========================================================================================
- Hits 52329 52305 -24
- Misses 5303 5309 +6
- Partials 1040 1045 +5
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
aad4df2
into
armcknight/feat/launch-profiling4-end-to-end-check
Follows #3634 and followed by #3636
Remove some global variables that are no longer needed now that we use a dedicated transaction for app launch.
Remove some old API from the backup config file strategy we no longer use. It was causing some build failures in tests.
Also some debug logs that were helpful to me.
#skip-changelog