fix(launch profiling): fix data wipe between integration test runs #3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngling config for the first launch to find on a subsequent run
armcknight
requested review from
philipphofmann and
brustolin
as code owners
This was referenced Feb 14, 2024
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cc00454 | 1213.73 ms | 1243.79 ms | 30.06 ms |
| 5641251 | 1223.64 ms | 1244.90 ms | 21.26 ms |
| 8a9a6b9 | 1237.59 ms | 1247.96 ms | 10.37 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cc00454 | 21.58 KiB | 422.39 KiB | 400.81 KiB |
| 5641251 | 21.58 KiB | 421.40 KiB | 399.82 KiB |
| 8a9a6b9 | 21.58 KiB | 422.49 KiB | 400.90 KiB |
philipphofmann
approved these changes
Feb 14, 2024
|
|
||
| private extension AppDelegate { | ||
| // previously tried putting this in an AppDelegate.load override in ObjC, but it wouldn't run until after a launch profiler would have an opportunity to run, since SentryProfiler.load would always run first due to being dynamically linked in a framework module. it is sufficient to do it before calling SentrySDK.startWIthOptions to clear state for testProfiledAppLaunches because we don't make any assertions on a launch profile the first launch of the app in that test | ||
| func maybeWipeData() { |
There was a problem hiding this comment.
l: We could rename this to wipeAppData and call it above when ProcessInfo.processInfo.arguments.contains("--io.sentry.wipe-data") is true. The name maybeWipeData is a bit confusing to me.
Co-authored-by: Philipp Hofmann <[email protected]>
…ch-traces' into armcknight/test/launch-profiling4-fix-data-wipe-between-integration-test-runs
…ch-traces' into armcknight/test/launch-profiling4-fix-data-wipe-between-integration-test-runs
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## armcknight/feat/launch-profiling3-create-dedicated-launch-traces #3633 +/- ##
======================================================================================================
+ Coverage 89.224% 89.265% +0.041%
======================================================================================================
Files 532 532
Lines 58663 58664 +1
Branches 21052 21048 -4
======================================================================================================
+ Hits 52342 52367 +25
+ Misses 5286 5266 -20
+ Partials 1035 1031 -4
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
armcknight
merged commit f45a7f7
into
armcknight/feat/launch-profiling3-create-dedicated-launch-traces
45 checks passed
armcknight
deleted the
armcknight/test/launch-profiling4-fix-data-wipe-between-integration-test-runs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #3621 and followed by #3634
I realized that wiping the app data didn't happen early enough to get before the app launch profile; instead of relying on it to happen automatically, be a little more careful of what is left behind in the first place in the integration test.
#skip-changelog