Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: Add reason for NSPrivacyAccessedAPICategoryFileTimestamp #3626

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Feb 12, 2024

📜 Description

Add C617.1 as reason to use NSPrivacyAccessedAPICategoryFileTimestamp to PrivacyInfo.xcprivacy.

💡 Motivation and Context

Fixes GH-3597

💚 How did you test it?

No test required.

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Add C617.1 as reason to use NSFileCreationDate to PrivacyInfo.xcprivacy.

Fixes GH-3597
@philipphofmann philipphofmann changed the title impr: Add reason for NSFileCreationDate impr: Add reason for NSPrivacyAccessedAPIType Feb 12, 2024
@philipphofmann philipphofmann changed the title impr: Add reason for NSPrivacyAccessedAPIType impr: Add reason for NSPrivacyAccessedAPICategoryFileTimestamp Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac8fd53) 89.345% compared to head (c037c62) 89.303%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3626       +/-   ##
=============================================
- Coverage   89.345%   89.303%   -0.042%     
=============================================
  Files          530       530               
  Lines        58283     58289        +6     
  Branches     20904     20909        +5     
=============================================
- Hits         52073     52054       -19     
- Misses        5185      5206       +21     
- Partials      1025      1029        +4     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8fd53...c037c62. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.41 ms 1233.55 ms 9.14 ms
Size 21.58 KiB 419.82 KiB 398.24 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4b22fc2 1192.15 ms 1217.31 ms 25.16 ms
2affdbd 1212.78 ms 1236.60 ms 23.82 ms
46f5eb8 1212.27 ms 1231.42 ms 19.15 ms
bb5dc7d 1240.44 ms 1266.45 ms 26.01 ms
4977fbc 1231.55 ms 1239.80 ms 8.25 ms
407ff99 1250.10 ms 1269.78 ms 19.67 ms
5d6ce0e 1227.57 ms 1241.08 ms 13.51 ms
2401cbd 1219.49 ms 1250.14 ms 30.65 ms
83d2d84 1211.31 ms 1227.34 ms 16.03 ms
e79ead7 1233.39 ms 1255.52 ms 22.13 ms

App size

Revision Plain With Sentry Diff
4b22fc2 22.85 KiB 414.11 KiB 391.26 KiB
2affdbd 22.85 KiB 411.37 KiB 388.52 KiB
46f5eb8 20.76 KiB 432.37 KiB 411.61 KiB
bb5dc7d 22.85 KiB 412.98 KiB 390.13 KiB
4977fbc 20.76 KiB 419.86 KiB 399.10 KiB
407ff99 20.76 KiB 427.87 KiB 407.10 KiB
5d6ce0e 22.85 KiB 405.38 KiB 382.53 KiB
2401cbd 22.85 KiB 408.85 KiB 386.00 KiB
83d2d84 20.76 KiB 419.66 KiB 398.90 KiB
e79ead7 20.76 KiB 426.11 KiB 405.35 KiB

@philipphofmann philipphofmann merged commit becc941 into main Feb 13, 2024
72 of 74 checks passed
@philipphofmann philipphofmann deleted the impr/ns-file-creation-date branch February 13, 2024 13:02
airtelshivam pushed a commit to airtelshivam/sentry-cocoa that referenced this pull request Apr 12, 2024
…ntry#3626)

Add C617.1 as reason to use NSFileCreationDate to PrivacyInfo.xcprivacy.

Fixes getsentryGH-3597

(cherry picked from commit becc941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain usage of NSFileCreationDate
2 participants