Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove redundant nonnull in FileManager #3591

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

philipphofmann
Copy link
Member

SentryFileManager has NS_ASSUME_NONNULL_BEGIN at the beginning. No need to specify nonnull for createPathsWithOptions.

#skip-changelog

SentryFileManager has NS_ASSUME_NONNULL_BEGIN at the beginning. No need
to specify nonnull for createPathsWithOptions.
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52e4912) 89.275% compared to head (0b10cb2) 89.269%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3591       +/-   ##
=============================================
- Coverage   89.275%   89.269%   -0.007%     
=============================================
  Files          529       529               
  Lines        57793     57770       -23     
  Branches     20682     20669       -13     
=============================================
- Hits         51595     51571       -24     
- Misses        5174      5287      +113     
+ Partials      1024       912      -112     
Files Coverage Δ
Sources/Sentry/SentryFileManager.m 93.736% <ø> (ø)

... and 40 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e4912...0b10cb2. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.78 ms 1234.27 ms 19.49 ms
Size 21.58 KiB 418.14 KiB 396.56 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a2af9fa 1236.62 ms 1253.12 ms 16.50 ms
f25febb 1209.08 ms 1225.90 ms 16.81 ms
7cd187e 1239.02 ms 1261.42 ms 22.40 ms
9cc7e7c 1228.90 ms 1237.96 ms 9.06 ms
3cb68af 1221.15 ms 1238.40 ms 17.25 ms
881a955 1222.16 ms 1237.22 ms 15.06 ms
5b6694b 1221.71 ms 1259.06 ms 37.35 ms
66922ca 1221.68 ms 1235.98 ms 14.30 ms
42ef6ba 1195.04 ms 1214.35 ms 19.31 ms
279841c 1231.41 ms 1245.65 ms 14.24 ms

App size

Revision Plain With Sentry Diff
a2af9fa 20.76 KiB 432.87 KiB 412.11 KiB
f25febb 21.58 KiB 414.92 KiB 393.34 KiB
7cd187e 20.76 KiB 401.65 KiB 380.89 KiB
9cc7e7c 22.84 KiB 403.13 KiB 380.29 KiB
3cb68af 20.76 KiB 401.60 KiB 380.84 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB
5b6694b 20.76 KiB 426.11 KiB 405.34 KiB
66922ca 20.76 KiB 425.80 KiB 405.04 KiB
42ef6ba 21.58 KiB 417.87 KiB 396.28 KiB
279841c 22.84 KiB 403.19 KiB 380.35 KiB

@philipphofmann philipphofmann merged commit 6e8d7e1 into main Jan 31, 2024
69 of 72 checks passed
@philipphofmann philipphofmann deleted the ref/remove-nonnull branch January 31, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants