test: use XCTUnwrap instead of force unwraps or unchecked array access #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3589 +/- ##
=============================================
- Coverage 89.289% 89.266% -0.024%
=============================================
Files 529 529
Lines 57737 57920 +183
Branches 20412 20734 +322
=============================================
+ Hits 51553 51703 +150
- Misses 5276 5302 +26
- Partials 908 915 +7
... and 71 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
armcknight
changed the base branch from
armcknight/feat/launch-profiling
to
main
avoids the test process crashing, and instead marks them as
failures so you can get the idea about all the tests that are
currently failing, instead of only the next one that crashes the
test run
armcknight
force-pushed
the
armcknight/test/convert-force-unwraps-to-XCTUnwrap
branch
from
63b0321
to
79a413d
Compare
armcknight
deleted the
armcknight/test/convert-force-unwraps-to-XCTUnwrap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed these while investigating a broken assumption that were crashing the test run instead of just failing these cases. Helps with #3576.
#skip-changelog