Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Properly teardown frames tracker #3545

Merged
merged 4 commits into from
Jan 5, 2024
Merged

ref: Properly teardown frames tracker #3545

merged 4 commits into from
Jan 5, 2024

Commits on Jan 5, 2024

  1. ref: Properly teardown frames tracker 

    The teardown of the SentryFramesTracker didn't work properly in tests.
The clearTestState method continuously initialized a new frames tracker
cause it accessed the property dependency container. This is fixed now
by calling SentryFramesTracker.stop directly in
SentryDependencyContainer.reset which is also called in clearTestState.
Furthermore, the SentryFramesTracker.stop now resets all frames and
removes all observers.
    @philipphofmann
    philipphofmann committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    e403a2c View commit details
    Browse the repository at this point in the history

  2. fix failing tests

    @philipphofmann
    philipphofmann committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d18e870 View commit details
    Browse the repository at this point in the history

  3. again fix tests

    @philipphofmann
    philipphofmann committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d6467a6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ref/frames-tracker-teardown

    @philipphofmann
    philipphofmann committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d16888b View commit details
    Browse the repository at this point in the history