Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump actions artifacts from 3 to 4 #3515

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Dec 19, 2023

Bumps actions/download-artifact from 3 to 4 and actions/upload-artifact from 3 to 4.

No migration changes required after looking at the migration guide because our artifacts of jobs using matrixes already reflect the matrix parameters in their names.

#skip-changelog

@philipphofmann philipphofmann changed the title first try ci: Bump actions artifacts from 3 to 4 Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #3515 (351e24d) into main (fac579e) will decrease coverage by 0.025%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3515       +/-   ##
=============================================
- Coverage   89.205%   89.181%   -0.025%     
=============================================
  Files          528       528               
  Lines        57476     57475        -1     
  Branches     20608     20609        +1     
=============================================
- Hits         51272     51257       -15     
+ Misses        5294      5189      -105     
- Partials       910      1029      +119     

see 43 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac579e...351e24d. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1199.20 ms 1224.31 ms 25.11 ms
Size 21.58 KiB 418.33 KiB 396.75 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b483671 1217.20 ms 1236.82 ms 19.62 ms
e758449 1243.41 ms 1246.71 ms 3.31 ms
db31083 1227.69 ms 1243.56 ms 15.87 ms
279841c 1231.41 ms 1245.65 ms 14.24 ms
7bb0873 1226.18 ms 1247.30 ms 21.12 ms
4886e79 1248.43 ms 1255.04 ms 6.61 ms
afd1a08 1207.78 ms 1223.44 ms 15.66 ms
983de17 1260.57 ms 1263.68 ms 3.11 ms
b9b0f0a 1235.61 ms 1237.40 ms 1.79 ms
ff09c7e 1244.86 ms 1246.68 ms 1.82 ms

App size

Revision Plain With Sentry Diff
b483671 20.76 KiB 434.72 KiB 413.96 KiB
e758449 22.85 KiB 407.62 KiB 384.77 KiB
db31083 22.85 KiB 407.63 KiB 384.78 KiB
279841c 22.84 KiB 403.19 KiB 380.35 KiB
7bb0873 22.85 KiB 407.09 KiB 384.24 KiB
4886e79 22.85 KiB 412.98 KiB 390.13 KiB
afd1a08 22.84 KiB 402.57 KiB 379.72 KiB
983de17 22.84 KiB 403.19 KiB 380.34 KiB
b9b0f0a 20.76 KiB 434.93 KiB 414.17 KiB
ff09c7e 20.76 KiB 427.77 KiB 407.00 KiB

@philipphofmann philipphofmann marked this pull request as ready for review December 19, 2023 15:22
@philipphofmann
Copy link
Member Author

@brustolin, I guess you missed this one ⬆️.

@philipphofmann philipphofmann merged commit ea2a263 into main Jan 2, 2024
52 of 53 checks passed
@philipphofmann philipphofmann deleted the ci/update-artifact-to-v4 branch January 2, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants