-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TTID/TTFD for app start transactions #3512
Conversation
The TTFD/TTID spans and measurements for app start transactions were wrong, as they didn't include the app start duration. This is fixed now. Fixes GH-3471
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3512 +/- ##
=============================================
+ Coverage 89.205% 89.223% +0.017%
=============================================
Files 528 528
Lines 57476 57570 +94
Branches 20608 20630 +22
=============================================
+ Hits 51272 51366 +94
Misses 5294 5294
Partials 910 910
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dc0db9e | 1222.10 ms | 1240.90 ms | 18.80 ms |
455619d | 1253.08 ms | 1265.06 ms | 11.98 ms |
279841c | 1250.80 ms | 1263.08 ms | 12.29 ms |
c78683b | 1246.71 ms | 1258.70 ms | 11.99 ms |
156e771 | 1228.06 ms | 1242.64 ms | 14.58 ms |
67460f4 | 1244.56 ms | 1255.96 ms | 11.40 ms |
6bc5ae5 | 1230.90 ms | 1246.10 ms | 15.20 ms |
b9b0f0a | 1239.76 ms | 1257.68 ms | 17.92 ms |
8f397a7 | 1236.76 ms | 1256.76 ms | 20.00 ms |
4afae53 | 1217.65 ms | 1229.27 ms | 11.62 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
455619d | 20.76 KiB | 432.87 KiB | 412.11 KiB |
279841c | 22.84 KiB | 403.19 KiB | 380.34 KiB |
c78683b | 20.76 KiB | 435.24 KiB | 414.48 KiB |
156e771 | 20.76 KiB | 419.70 KiB | 398.94 KiB |
67460f4 | 20.76 KiB | 426.15 KiB | 405.39 KiB |
6bc5ae5 | 20.76 KiB | 401.40 KiB | 380.64 KiB |
b9b0f0a | 20.76 KiB | 434.94 KiB | 414.18 KiB |
8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
4afae53 | 22.84 KiB | 402.08 KiB | 379.24 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- TTID/TTFD for app start transactions ([#3512](https://github.com/getsentry/sentry-cocoa/pull/3512)) If none of the above apply, you can opt out of this check by adding |
📜 Description
The TTFD/TTID spans and measurements for app start transactions were wrong, as they didn't include the app start duration. This is fixed now.
This PR is based on #3505.
💡 Motivation and Context
Fixes GH-3471
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps