Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: move fcd to where its actually used #3499

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

armcknight
Copy link
Member

small simple refactor of something i noticed while reading code

#skip-changelog

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #3499 (dc4f2bc) into main (de033da) will increase coverage by 0.029%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3499       +/-   ##
=============================================
+ Coverage   89.163%   89.193%   +0.029%     
=============================================
  Files          528       528               
  Lines        57224     57435      +211     
  Branches     20260     20581      +321     
=============================================
+ Hits         51023     51228      +205     
- Misses        5286      5293        +7     
+ Partials       915       914        -1     

see 73 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de033da...dc4f2bc. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1201.22 ms 1218.46 ms 17.24 ms
Size 21.58 KiB 418.15 KiB 396.57 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b064665 1230.04 ms 1254.08 ms 24.04 ms
ddc9b9a 1210.00 ms 1234.18 ms 24.18 ms
50bbebb 1234.76 ms 1246.66 ms 11.90 ms
2154ae1 1216.06 ms 1244.78 ms 28.72 ms
e7b566f 1199.57 ms 1218.76 ms 19.19 ms
fb53d97 1226.08 ms 1245.12 ms 19.04 ms
e8b11f8 1233.66 ms 1249.74 ms 16.08 ms
881a955 1230.69 ms 1244.12 ms 13.43 ms
3437454 1254.04 ms 1259.50 ms 5.46 ms
5ab598f 1213.90 ms 1240.45 ms 26.55 ms

App size

Revision Plain With Sentry Diff
b064665 22.85 KiB 413.42 KiB 390.57 KiB
ddc9b9a 20.76 KiB 420.40 KiB 399.64 KiB
50bbebb 21.58 KiB 414.96 KiB 393.38 KiB
2154ae1 20.76 KiB 427.83 KiB 407.06 KiB
e7b566f 22.85 KiB 414.80 KiB 391.95 KiB
fb53d97 20.76 KiB 425.81 KiB 405.04 KiB
e8b11f8 22.85 KiB 411.92 KiB 389.07 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB
3437454 22.85 KiB 408.87 KiB 386.02 KiB
5ab598f 22.84 KiB 403.17 KiB 380.33 KiB

@armcknight armcknight merged commit e02158b into main Dec 15, 2023
69 of 70 checks passed
@armcknight armcknight deleted the armcknight/ref/fcd branch December 15, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants