ci: remove TrendingMovies and profile data generation CI job #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
requested review from
philipphofmann and
brustolin
as code owners
armcknight
changed the base branch from
main
to
ci/remove-profiling-test-data-schedule
armcknight
force-pushed
the
armcknight/ci/removing-obsoleted-jobs
branch
2 times, most recently
from
e423c18
to
0394604
Compare
armcknight
force-pushed
the
armcknight/ci/removing-obsoleted-jobs
branch
from
0394604
to
97f536e
Compare
brustolin
approved these changes
Nov 29, 2023
armcknight
merged commit b8c5162
into
ci/remove-profiling-test-data-schedule
21 of 22 checks passed
|
@armcknight, the changes of this PR haven't ended up in main yet. Please open another PR. |
|
Are you sure? Should be in main after #3451 was merged. I don't see any of the files/directories that were deleted after updating my local clone |
Ah, I missed that one. Thanks 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the profiling feature has been GA for a while and our system is stress tested with customer traffic, and we don't use the TrendingMovies app to validate SDK changes (which we can now turn to https://github.com/sentry-demos/ios for) we can entirely remove that test app and the associated CI job from our SDK repo.
#skip-changelog