Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove unnecessary imports #3256

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Aug 25, 2023

📜 Description

  • don't import <Sentry/Sentry.h> in test code. many were innocuous, some needed the actually tested classes imported
  • found an empty test case, removed the file
  • removed a few unneeded imports of <XCTest/XCTest.h>

💡 Motivation and Context

There is some weird stuff going on with transitive imports that is breaking some CI jobs in other refactor PRs. Trying to clean it up and cut transitive ties.

#skip-changelog

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #3256 (a21078a) into main (5d6ce0e) will increase coverage by 0.044%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3256       +/-   ##
=============================================
+ Coverage   89.150%   89.195%   +0.044%     
=============================================
  Files          502       501        -1     
  Lines        54113     54114        +1     
  Branches     19428     19418       -10     
=============================================
+ Hits         48242     48267       +25     
+ Misses        5011      4992       -19     
+ Partials       860       855        -5     
Files Changed Coverage Δ
...s/SentryTests/Helper/SentrySerializationNilTests.m 100.000% <ø> (ø)
Tests/SentryTests/Helper/SentrySwizzleTests.m 89.690% <ø> (ø)
Tests/SentryTests/Networking/SentryDsnTests.m 100.000% <ø> (ø)
Tests/SentryTests/SentryInterfacesTests.m 100.000% <ø> (ø)
...ts/SentryTests/SentryKSCrashReportConverterTests.m 96.978% <ø> (ø)
Tests/SentryTests/SentryNSDataCompressionTests.m 100.000% <ø> (ø)
Tests/SentryTests/SentryScope+Equality.m 28.070% <ø> (ø)
Tests/SentryTests/SentryTests.m 100.000% <ø> (ø)
Tests/SentryTests/TestLogOutput.swift 100.000% <ø> (ø)
...SentryTests/TestUtils/SentryBooleanSerialization.m 100.000% <ø> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d6ce0e...a21078a. Read the comment docs.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

LGTM

@armcknight armcknight merged commit aa26ebb into main Aug 29, 2023
52 of 53 checks passed
@armcknight armcknight deleted the armcknight/ref/remove-blanket-transitive-import branch August 29, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants