-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WatchOS build for Xcode 15 #3204
Conversation
#elif TARGET_OS_WATCH | ||
# import <WatchKit/WatchKit.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This don't make sense.
Apple own header have errors inside, maybe this will be solved until Xcode 15 release, but we don't even use this, so there is no harm in removing it and save a few bits.
…-cocoa into fix/watch-build-xcode15
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3204 +/- ##
=============================================
+ Coverage 89.139% 89.198% +0.058%
=============================================
Files 502 502
Lines 54041 54028 -13
Branches 19384 19383 -1
=============================================
+ Hits 48172 48192 +20
+ Misses 5013 4875 -138
- Partials 856 961 +105
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
60dd0f5 | 1247.35 ms | 1267.59 ms | 20.24 ms |
15b8c61 | 1223.16 ms | 1244.83 ms | 21.67 ms |
8f397a7 | 1224.66 ms | 1236.48 ms | 11.82 ms |
0001a09 | 1223.90 ms | 1249.56 ms | 25.66 ms |
257c2a9 | 1239.52 ms | 1251.08 ms | 11.56 ms |
3f366ee | 1244.49 ms | 1257.28 ms | 12.79 ms |
3e7aa41 | 1214.02 ms | 1238.84 ms | 24.82 ms |
47b41ed | 1252.31 ms | 1253.96 ms | 1.64 ms |
25bcc50 | 1209.53 ms | 1224.86 ms | 15.33 ms |
c00eafe | 1198.26 ms | 1227.62 ms | 29.36 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
60dd0f5 | 20.76 KiB | 393.37 KiB | 372.60 KiB |
15b8c61 | 20.76 KiB | 419.67 KiB | 398.91 KiB |
8f397a7 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
0001a09 | 20.76 KiB | 433.19 KiB | 412.43 KiB |
257c2a9 | 20.76 KiB | 401.36 KiB | 380.60 KiB |
3f366ee | 20.76 KiB | 427.84 KiB | 407.08 KiB |
3e7aa41 | 20.76 KiB | 432.31 KiB | 411.55 KiB |
47b41ed | 20.76 KiB | 436.66 KiB | 415.90 KiB |
25bcc50 | 20.76 KiB | 427.22 KiB | 406.46 KiB |
c00eafe | 20.76 KiB | 432.87 KiB | 412.11 KiB |
Previous results on branch: fix/watch-build-xcode15
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9c0bd78 | 1225.18 ms | 1250.14 ms | 24.96 ms |
0f5f6a1 | 1242.98 ms | 1261.41 ms | 18.43 ms |
c1198d0 | 1233.77 ms | 1242.37 ms | 8.60 ms |
7fb6c19 | 1226.76 ms | 1246.65 ms | 19.90 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9c0bd78 | 22.84 KiB | 403.19 KiB | 380.35 KiB |
0f5f6a1 | 22.84 KiB | 403.19 KiB | 380.35 KiB |
c1198d0 | 22.84 KiB | 403.19 KiB | 380.35 KiB |
7fb6c19 | 22.84 KiB | 403.19 KiB | 380.35 KiB |
I pushed a commit that fixed a couple build errors when I tried running this locally. Not sure how the watchOS samples ever worked before this. One was:
The other was an error complaining that the embedded binary wasn't signed with the same cert as the parent app. |
Strange, i had no problem running the sample here. |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- WatchOS build for Xcode 15 ([#3204](https://github.com/getsentry/sentry-cocoa/pull/3204)) If none of the above apply, you can opt out of this check by adding |
📜 Description
Fixed WatchOS build for Xcode 15
💡 Motivation and Context
close #3203
💚 How did you test it?
Samples
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps