-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: scripts should propagate errors #3197
Conversation
e223a62
to
e44a647
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3197 +/- ##
=============================================
- Coverage 89.204% 89.196% -0.008%
=============================================
Files 502 502
Lines 54058 54046 -12
Branches 19405 19391 -14
=============================================
- Hits 48222 48207 -15
+ Misses 4986 4877 -109
- Partials 850 962 +112
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
e44a647
to
fe78f05
Compare
fe78f05
to
15683e2
Compare
- 'scripts/ci-select-xcode.sh' | ||
- 'scripts/xcode-test.sh' | ||
- '.codecov.yml' | ||
- "Sources/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the quotes - it's auto-formatted by vscode. I can roll this back manually if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
💡 Motivation and Context
In another PR, I've noticed some scripts don't error-out if there's a failure, e.g. this test build failure.
This makes it harder to find actual cause of a failure down the road.
Instead, scripts should fail when an error occurs - this is what this PR does. After changing the scripts, I've also had to make a few fixes that for the newly discovered issues.
However, there's one bigger issue with thread-sanitizer. It hasn't been running because it failed after a build due to malformed command. After fixing the call, the sanitizer fails. I suggest disabling the thread sanitizer step in CI for now and fixing its errors in a separate maintenance issue. See latest log: https://github.com/getsentry/sentry-cocoa/suites/14737489895/artifacts/837486751
#skip-changelog
💚 How did you test it?
Checked that there are no CI failures.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps