-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): Add features to client sdks #3478
Conversation
This PR adds features to the ClientSDKInfo. Related develop docs PR: getsentry/develop#1244.
It seems like something is wrong with the signing of these packages.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A list can only track enabled features, would we be interested in tracking some other initialization values for future compatibility? For example, one can't tell the difference between a sample_rate=0.7
vs sample_rate=1
with just a list. This is solved with an object, in which we forward unknown attributes and thus leave the door open for future extension.
(sorry for getting a bit late here)
The purpose is only to track enabled features. If we want to track something like |
Sgtm then 👍 For CI failures, rerunning jobs should be good enough. Seems like something was off in GitHub jobs |
This PR adds features to the ClientSDKInfo. Related develop docs PR: getsentry/develop#1244 and team SDK GH issue: getsentry/team-sdks#83.