Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable file system analyzer warning #6

Closed
wants to merge 1 commit into from

Conversation

RRode
Copy link

@RRode RRode commented Nov 10, 2024

Related to #3643

Disables the custom analyzer check

@jamescrosswell
Copy link
Collaborator

@RRode thanks so much for the pull request.

We haven't been making any significant changes in the main branch in this fork so despite the fact that you made a fairly trivial change in your PR, none of the CI checks pass.

Rather than trying to address that now, I've created an issue in the sentry-dotnet repository to make sure that happens later.

I've also cherry picked the changes from this PR and pushed these up to an internal branch on this repository. I'll add a comment getsentry/sentry-dotnet#3725 describing how you can check these out and apply them in the main PR that you're making for the Filesystem usage analyzer.

Consequently, this PR shouldn't be necessary and I'll close it.

@RRode RRode deleted the disable-analyzer branch November 13, 2024 20:49
@RRode
Copy link
Author

RRode commented Nov 13, 2024

@jamescrosswell thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants