Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secret-scan): skip curl if env var not available #148

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

Jeffreyhung
Copy link
Member

Due to security design in GitHub, the vars.SECRET_SCAN_PANTHER_WEBHOOK_URL will not be exposed to outside collaborators who open PRs on our repos, which cause the secret scanner to fail.
Adding an if statement and do nothing if the var is not available.

@Jeffreyhung Jeffreyhung requested a review from a team November 7, 2024 01:26
@Jeffreyhung Jeffreyhung enabled auto-merge (squash) November 7, 2024 01:31
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loogs good to me!

@Jeffreyhung Jeffreyhung merged commit f2a9fd9 into main Nov 7, 2024
2 checks passed
@Jeffreyhung Jeffreyhung deleted the fix-secret-scanning branch November 7, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants