Move styles from SubmissionComment to MarkdownTextarea #776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was randomly looking at
SubmissionComment
and noticed that it sets styles on#submission-comment-actions
. However, it looks like there isn't a#submission-comment-actions
element anymore: I think that element was moved intoMarkdownTextarea
as part of #483 more than a year ago. This PR moves the styles fromSubmissionComment
intoMarkdownTextarea
, though given that they haven't been in use for a while, we'd probably also be fine removing them.The styles do two things:
I've recorded the current behavior (without these styes) and the behavior with these styles. I slowed down the animation in the recording so that it's easier to see.
Current behavior (without styles):
Screen.Recording.2023-04-10.at.2.38.18.PM.mov
With styles:
Screen.Recording.2023-04-10.at.2.33.36.PM.mov
@ktuite, do you remember these styles at all? Do you know whether we intended to remove them?
Before submitting this PR, please make sure you have:
npm run test
andnpm run lint
and confirmed all checks still pass OR confirm CircleCI build passes