Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make feedback button more visible #1066

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Nov 26, 2024

Closes getodk/central#673

What has been done to verify that this works as intended?

Ran it locally.

Why is this the best possible solution? Were any other approaches considered?

I ended up with 250px from the bottom. That feels like a good balance of more eye catching but not too disruptive, especially in languages where the button text is longer and on smaller screens like laptops (common).

@alyblenkin please take a quick look and if you're not loving it, let's adjust on a call next time we chat!

Here are screenshots from a 14" laptop screen:

500px FR 250px FR 250px EN
Screenshot 2024-11-25 at 4 25 37 PM Screenshot 2024-11-25 at 4 26 08 PM Screenshot 2024-11-25 at 4 26 25 PM

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

CSS-only changes

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding magenta outline to feedback button
1 participant