Make feedback button more visible #1066
Draft
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#673
What has been done to verify that this works as intended?
Ran it locally.
Why is this the best possible solution? Were any other approaches considered?
I ended up with 250px from the bottom. That feels like a good balance of more eye catching but not too disruptive, especially in languages where the button text is longer and on smaller screens like laptops (common).
@alyblenkin please take a quick look and if you're not loving it, let's adjust on a call next time we chat!
Here are screenshots from a 14" laptop screen:
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
CSS-only changes
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
npm run test
andnpm run lint
and confirmed all checks still pass OR confirm CircleCI build passes