-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serverside-persisted user preferences #1021
Closed
brontolosone
wants to merge
13
commits into
getodk:master
from
brontolosone:central_689-userpreferences-rb
Closed
Serverside-persisted user preferences #1021
brontolosone
wants to merge
13
commits into
getodk:master
from
brontolosone:central_689-userpreferences-rb
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vron-right have unequal width
This was referenced Sep 4, 2024
Instead of replacing serverside user preference state wholesale with what the client thinks the state is (which would clobber any changes made in other client instantiations), patch up server state incrementally.
brontolosone
force-pushed
the
central_689-userpreferences-rb
branch
from
September 6, 2024 17:50
6d7d8ca
to
c9279bf
Compare
Needs to be updated as the backend has changed quite a bit (getodk/central-backend@bd62997) |
Closing; superseded by #1024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards getodk/central#689
Supersedes #1018
Related: getodk/central-backend#1184
This introduces persistent user preferences as per getodk/central#689.
The backend (see getodk/central-backend#1184) simply stores the json-serialized user-associated preferences object; the preferences themselves are opaque to the backend.
The semantics of the preferences object are completely up to the frontend.
Implemented preferences:
Todo:
Design choices made
The preferences object
org.getodk.central-frontend
) in it, so that the backend scopes operations to the json under that key.We could fold "frontend app identifier" and "schema version" in one, and use app identifier keys such as
org.getodk.central-frontend.1
where we bump the last number for every incompatible schema change, in fact treating them as different frontends, which in fact they are.Considerations on this: K: let's think about it more
Concurrent sessions