Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for cross-language magic links #3812

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Better support for cross-language magic links #3812

wants to merge 5 commits into from

Conversation

gudzpoz
Copy link
Contributor

@gudzpoz gudzpoz commented Jan 17, 2025

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

This PR implements the changes described #3811:

  • If the user specifies lang via link://.../...?lang=some_lang, pass some_lang as the lang parameter to the corresponding path resolver.
  • Fix link://filename/... to handle multilingual posts.

closes #3811

@gudzpoz gudzpoz force-pushed the magic-link-lang branch 4 times, most recently from 9250b10 to d1b366f Compare January 18, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support cross-language magic links
1 participant
@gudzpoz