Fix api-deployment template, references to s3.aws from values and add minio tar.gz file #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cambelau
changed the title
|
Hello @Cambelau, thank you for this PR! Indeed, as I conducted my tests on a GCP cluster, I introduced some errors... Thanks for this bug fix 🙏 ! |
electrosenpai
approved these changes
Oct 11, 2024
electrosenpai
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean reopening of #76
Changes
s3.aws.*which were renamed tos3.*in PR feat(minio): add MinIO support alongside AWS S3 #66Impact