feat(helm): add support for extraEnv variables in api, front, worker, events-worker, clock, and pdf deployments for dynamic environment configuration #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… events-worker, clock, and pdf deployments for dynamic environment configuration
jdenquin
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following changes:
feat(helm): Support for
extraEnvvariablesAdded support for dynamic environment variables via the
extraEnvsection in thevalues.yamlfor the following deployments:apifrontworkerevents-workerclockpdffix(pvc): Resolved conditional issue in PVC template
Fixed the logic error in the PersistentVolumeClaim template where multiple
notconditions were incorrectly applied, causing template rendering issues. Now the PVC is correctly created when boths3.enabledandminio.enabledare set tofalse.Motivation
These changes allow users to configure additional environment variables without directly modifying the deployment templates, providing greater flexibility. For example, it was previously impossible to enable the
LAGO_DISABLE_WALLET_REFRESHenvironment variable, despite it being documented. To avoid this issue and to allow for the dynamic addition of new arguments in the future without causing breaking changes, this approach offers a more sustainable solution.The PVC issue was also resolved to ensure that the persistent volume is only created under the correct conditions.