Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance API and Frontend Configuration Documentation and Default PVC Handling #71

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

electrosenpai
Copy link
Contributor

This pull request improves the documentation for both the API and frontend configurations by adding missing parameters and clarifying default behaviors. The following changes have been made:

  • API Configuration: Added documentation for missing parameters such as logStdout, logLevel, sidekiqWeb.enabled, volumes.accessModes, volumes.storage, podAnnotations, and podLabels.
  • Frontend Configuration: Included documentation for podAnnotations and podLabels parameters.
  • Persistent Volume Claim (PVC) Handling: Clarified that the default behavior is to fallback to a PVC if neither S3 nor MinIO is configured, although this is strongly discouraged.

This PR aims to provide clearer guidance on configuration options and their defaults, improving overall usability and deployment reliability.

@electrosenpai electrosenpai merged commit e5ca0e3 into main Sep 26, 2024
1 check passed
@electrosenpai electrosenpai deleted the removing-pvc branch October 29, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants