Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): update GitHub workflow and Helm config #122

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

electrosenpai
Copy link
Contributor

Description

This pull request introduces several changes to the GitHub Action workflow:

  • Change of release files location: The release files are now stored in the artifacts/ directory instead of charts/. This prevents conflicts when creating Helm packages due to dependencies within Helm.

  • Added default values for apiUrl and frontUrl: Previously, if these values were commented out, Helm would ignore them, causing the following error:

$ helm template my-lago lago/lago --version 1.15.0 --set lago.apiUrl=https://api.domain.tld/ --set lago.frontUrl=https://app.domain.tld/ --debug install.go:218: [debug] Original chart version: "1.15.0" install.go:235: [debug] CHART PATH: /home/pb/.cache/helm/repository/lago-1.15.0.tgz

Error: execution error at (lago/templates/worker-deployment.yaml:68:24): apiUrl value is required helm.go:84: [debug] execution error at (lago/templates/worker-deployment.yaml:68:24): apiUrl value is required

This should fix issue #120

  • Added Helm packages to .helmignore: Helm was previously including these packages inside new packages by default, which quickly inflated the package size. This led to the following error:
charts helm install my-lago lago2/lago --version 1.15.4 --values value_old.yaml
Error: INSTALLATION FAILED: create: failed to create: Request entity too large: limit is 3145728

@electrosenpai electrosenpai merged commit 1ddda14 into main Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants