chore(release): update GitHub workflow and Helm config #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several changes to the GitHub Action workflow:
Change of release files location: The release files are now stored in the
artifacts/
directory instead ofcharts/
. This prevents conflicts when creating Helm packages due to dependencies within Helm.Added default values for
apiUrl
andfrontUrl
: Previously, if these values were commented out, Helm would ignore them, causing the following error:$ helm template my-lago lago/lago --version 1.15.0 --set lago.apiUrl=https://api.domain.tld/ --set lago.frontUrl=https://app.domain.tld/ --debug install.go:218: [debug] Original chart version: "1.15.0" install.go:235: [debug] CHART PATH: /home/pb/.cache/helm/repository/lago-1.15.0.tgz Error: execution error at (lago/templates/worker-deployment.yaml:68:24): apiUrl value is required helm.go:84: [debug] execution error at (lago/templates/worker-deployment.yaml:68:24): apiUrl value is required
This should fix issue #120
.helmignore
: Helm was previously including these packages inside new packages by default, which quickly inflated the package size. This led to the following error: