feat: Invoice amount filter #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansmonjol
approved these changes
Jan 9, 2025
stephenlago99
force-pushed
the
feat-invoice-amount-filter
branch
from
898e4a6 to
feb6ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR enables filtering invoices by amount. A big chunk of the work was done previously for the Credit notes export feature.
Description
Most of the change is just including the amount filter in invoice-related logic.
This change also includes an improvement to the query filtering logic, by making it consistent between credit notes and invoices. This should help us in the future if we want to also filter other entities.