feat: handle invoice tax status pending #1937
Open
+116
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keellyp
approved these changes
Dec 24, 2024
ansmonjol
force-pushed
the
feat-anrok-async
branch
from
2d884c9 to
84a819c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When interacting with Anrok, jobs are handled asynchronously.
Now they can also be re-triggered after a fail, and enqueued so stuck in a "pending" state.
To represent that, we introduce new states on Invoice model
status:pendingtaxStatus- that have valuefailed,pendingandsucceededDescription
This PR makes sure the pending states are correctly represented and handled on our side:
Please note we mostly rely on taxStatus to compute our logic, but invoice status should also be check almost in any cases.
This is more relevant as it's possible to have an invoice in this state:
draftpendingFixes LAGO-629