Skip to content

Commit

Permalink
fix: product design review
Browse files Browse the repository at this point in the history
  • Loading branch information
keellyp committed Jan 14, 2025
1 parent 3b2032c commit 147651b
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -182,16 +182,15 @@ export const EditCustomerInvoiceCustomSectionsDialog = forwardRef<
{formikProps.values.behavior === BehaviorType.CUSTOM_SECTIONS && (
<MultipleComboBox
hideTags={false}
forcePopupIcon
name="applicableInvoiceCustomSectionIds"
data={
data?.invoiceCustomSections?.collection
.filter(({ selected }) => !selected)
.map((section) => ({
labelNode: section.name,
label: section.name,
description: section.code,
value: section.id,
})) ?? []
data?.invoiceCustomSections?.collection.map((section) => ({
labelNode: section.name,
label: section.name,
description: section.code,
value: section.id,
})) ?? []
}
onChange={(section) =>
formikProps.setFieldValue(
Expand All @@ -213,7 +212,7 @@ export const EditCustomerInvoiceCustomSectionsDialog = forwardRef<
}
placeholder={translate('text_1735223938916qvvv12r7je0')}
PopperProps={{ displayInDialog: true }}
emptyText={translate('text_1735223938916tlygbi5v0nd')}
emptyText={translate('text_173642092241713ws50zg9v4')}
/>
)}
<RadioField
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ export const PreviewCustomSectionDrawer = forwardRef<PreviewCustomSectionDrawerR
withPadding={false}
stickyBottomBar={({ closeDrawer }) => (
<div className="flex justify-end">
<Button onClick={closeDrawer}>{translate('text_62f50d26c989ab03196884ae')}</Button>
<Button size="large" onClick={closeDrawer}>
{translate('text_62f50d26c989ab03196884ae')}
</Button>
</div>
)}
title={
Expand All @@ -75,7 +77,7 @@ export const PreviewCustomSectionDrawer = forwardRef<PreviewCustomSectionDrawerR
}
>
<div className="h-full bg-grey-100 pb-12 pl-12">
<div className="flex size-full flex-col justify-end bg-white px-12 py-8">
<div className="flex size-full flex-col justify-end bg-white p-12">
{hasLocalData && (
<div className="flex flex-col gap-1 pb-6 shadow-b">
{localData?.displayName && (
Expand Down
2 changes: 2 additions & 0 deletions src/pages/settings/Invoices/CreateCustomSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ const CreateInvoiceCustomSection = () => {
</div>
<div className="flex items-start gap-6 *:flex-1">
<TextInputField
// eslint-disable-next-line jsx-a11y/no-autofocus
autoFocus
name="name"
formikProps={formikProps}
label={translate('text_6419c64eace749372fc72b0f')}
Expand Down
5 changes: 3 additions & 2 deletions translations/base.json
Original file line number Diff line number Diff line change
Expand Up @@ -2770,5 +2770,6 @@
"text_1735223938916dhd7cyzokib": "Do not display custom sections on customers’ invoices",
"text_1735223938916q9pq0j0z0ju": "Edit behavior",
"text_1735223938916qvvv12r7je0": "Search and select a custom section",
"text_17352280436833uy9uxzbqn7": "Invoice custom section behavior successfully applied"
}
"text_17352280436833uy9uxzbqn7": "Invoice custom section behavior successfully applied",
"text_173642092241713ws50zg9v4": "No custom section available"
}

0 comments on commit 147651b

Please sign in to comment.