-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(invoice_custom_sections): add create_invoice_applied_custom_sections service #3008
Merged
annvelents
merged 19 commits into
feat-invoice-custom-sections-api-controller
from
feat-invoice-custom-sections-create-applied-service
Jan 14, 2025
Merged
Feat(invoice_custom_sections): add create_invoice_applied_custom_sections service #3008
annvelents
merged 19 commits into
feat-invoice-custom-sections-api-controller
from
feat-invoice-custom-sections-create-applied-service
Jan 14, 2025
+318
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
changed the title
add create_invoice_applied_custom_sections service
Feat(invoice_custojm_sections): add create_invoice_applied_custom_sections service
Dec 26, 2024
annvelents
force-pushed
the
feat-invoice-custom-sections-api-controller
branch
from
December 30, 2024 16:22
232645c
to
8e753ee
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-create-applied-service
branch
from
December 30, 2024 16:29
16bb00c
to
28e44be
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-create-applied-service
branch
from
January 7, 2025 13:33
28e44be
to
30325ba
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-api-controller
branch
from
January 9, 2025 14:47
8d3de8e
to
8927cbe
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-create-applied-service
branch
from
January 9, 2025 16:57
30325ba
to
4ea553a
Compare
vincent-pochet
approved these changes
Jan 10, 2025
@@ -0,0 +1,25 @@ | |||
# frozen_string_literal: true | |||
|
|||
RSpec.shared_examples 'applies invoice_custom_sections' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
nudded
changed the title
Feat(invoice_custojm_sections): add create_invoice_applied_custom_sections service
Feat(invoice_custom_sections): add create_invoice_applied_custom_sections service
Jan 10, 2025
Use applied invoice custom sections in PDFs and include them in invoice payload Also includes fixes found after QA
annvelents
merged commit Jan 14, 2025
05864a3
into
feat-invoice-custom-sections-api-controller
3 checks passed
annvelents
deleted the
feat-invoice-custom-sections-create-applied-service
branch
January 14, 2025 08:40
annvelents
added a commit
that referenced
this pull request
Jan 14, 2025
…ions service (#3008) ## Description Add a service to create applied invoice custom sections for invoices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a service to create applied invoice custom sections for invoices