-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat (invoice_custom_sections): refactor invoice_custom_sections inclusion #3006
Merged
annvelents
merged 31 commits into
main
from
feat-invoice-custom-sections-customer-update-mutation
Jan 9, 2025
Merged
Feat (invoice_custom_sections): refactor invoice_custom_sections inclusion #3006
annvelents
merged 31 commits into
main
from
feat-invoice-custom-sections-customer-update-mutation
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annvelents
changed the title
refactor invoice_custom_sections inclusion
Feat (invoice_custom_sections): refactor invoice_custom_sections inclusion
Dec 26, 2024
ancorcruz
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved... left a few comments.
spec/support/shared_examples/applied_invoice_custom_sections.rb
Outdated
Show resolved
Hide resolved
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-update-mutation
branch
from
December 30, 2024 14:14
6ecaf98
to
1151333
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-update-service
branch
from
December 30, 2024 15:42
2e1e5f6
to
20472d8
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-update-mutation
branch
2 times, most recently
from
December 30, 2024 16:06
8dba59d
to
b99d81b
Compare
ancorcruz
approved these changes
Jan 3, 2025
db/migrate/20241227154337_add_code_uniqueness_constraint_on_invoice_custom_sections.rb
Outdated
Show resolved
Hide resolved
ancorcruz
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Base automatically changed from
feat-invoice-custom-sections-customer-update-service
to
main
January 9, 2025 10:42
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-update-mutation
branch
from
January 9, 2025 10:55
659eef9
to
7870b8d
Compare
annvelents
force-pushed
the
feat-invoice-custom-sections-customer-update-mutation
branch
from
January 9, 2025 13:32
7870b8d
to
15a84d4
Compare
annvelents
deleted the
feat-invoice-custom-sections-customer-update-mutation
branch
January 9, 2025 14:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Included invoice_custom_sections into customer object rather than a separate resolver
Include invoice_custom_section management from customer update mutation