feat: Add payment type and reference #3003
Open
+72
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomiguelpinto
changed the title
brunomiguelpinto
changed the title
annvelents
reviewed
Dec 27, 2024
|
|
||
| safety_assured do | ||
| change_table :payments, bulk: true do |t| | ||
| t.column :payment_type, :enum, enum_type: 'payment_type', null: true |
There was a problem hiding this comment.
will we need index on this column?
There was a problem hiding this comment.
Yes good catch I will add it
annvelents
reviewed
Dec 27, 2024
| disable_ddl_transaction! | ||
|
|
||
| def up | ||
| add_column :invoices, :total_paid_amount_cents, :bigint, null: true, default: 0 |
There was a problem hiding this comment.
will in the future we update the existing paid invoices with real values? 🤔
There was a problem hiding this comment.
Yes I will do a migration to fill the values i was thinking on another pr but can be on this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR lays the groundwork for implementing manual/partial payment functionality in our system. It introduces necessary changes to the payments and invoices tables to enable the tracking and management of these new payment types and statuses.
Description
Migration: Add
payment_typeand reference columns to paymentspayment_typecolumn as an ENUM with values provider and manual.referencecolumn to store additional metadata for payments.Migration: Add
total_paid_amount_centscolumn to invoicestotal_paid_amount_centscolumn to track the cumulative amount paid toward an invoice.