misc(worker): Replace Sidekiq with SolidQueue #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
misc-solid-queue
branch
5 times, most recently
from
4a989d2 to
5960dd8
Compare
vincent-pochet
force-pushed
the
misc-solid-queue
branch
3 times, most recently
from
e071bfc to
544640d
Compare
vincent-pochet
force-pushed
the
misc-solid-queue
branch
19 times, most recently
from
f474c0b to
46ae840
Compare
vincent-pochet
force-pushed
the
misc-solid-queue
branch
from
125ad85 to
baa28cf
Compare
vincent-pochet
force-pushed
the
misc-solid-queue
branch
2 times, most recently
from
fb10c83 to
ade960f
Compare
vincent-pochet
changed the title
vincent-pochet
force-pushed
the
misc-solid-queue
branch
from
ade960f to
49f43b7
Compare
vincent-pochet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request replaces Sidekiq with SolidQueue as an ActiveJob backend.
The main advantage is that it takes advantage of the database to store jobs related data, making it more reliable than redis.
It also replaces the clock system based on
Clockworkin favor of the new internalrecurringsystem of SolidQueueNOTE: For a period of time, both Sidekiq and SolidQueue workers will have to keep running in parallel to make sure that every enqueued jobs will be processed. All new jobs will be sent to the new backend. THIS PART IS STILL A WORK IN PROGRESS