Skip to content

Commit

Permalink
misc: Stop tracking clickhouse schema (#2309)
Browse files Browse the repository at this point in the history
## Context

Today the `db/clickhouse_schema.rb` is tracked in git. This file
contains "sensitive" data like the Kafka URL and password (for local
env).

In order to avoid comiting these sensitive data, a `clickhouse:filter`
rake task was added to obfuscate the values.

As CI tasks are performing the full clickhouse migrations, it appears
that the shema.rb file is actually not mandatory at all and could be
removed from the git repository.

## Description

This PR:
- Removes the `db/clickhouse_schema.rb` file
- Add the  `db/clickhouse_schema.rb` in the untracked files
- Remove the `clickhouse:filter` rake task
  • Loading branch information
vincent-pochet authored Jul 19, 2024
1 parent f3d17bf commit 6a7acbe
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 165 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
run: bin/rails db:schema:load:primary
- name: Set up Clickhouse database schema
run: bin/rails db:migrate:clickhouse
- name: Set up Clickhouse database schema
- name: Dump Clickhouse database schema
run: bin/rails db:schema:dump:clickhouse
- name: Run tests
run: bundle exec rspec
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
!/tmp/storage/
!/tmp/storage/.keep
db/events_schema.rb
db/clickhouse_schema.rb

.env
.byebug_history
Expand Down
135 changes: 0 additions & 135 deletions db/clickhouse_schema.rb

This file was deleted.

29 changes: 0 additions & 29 deletions lib/tasks/db.rake

This file was deleted.

0 comments on commit 6a7acbe

Please sign in to comment.