Models sections: non-mutating items computed
#6480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianallgeier
approved these changes
Jun 12, 2024
bastianallgeier
deleted the
v5/refactor/nonmutating-modelssection-items-computed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
itemscomputed maps the items by returning new objects instead of mutating the model parameter directlyReasoning
In Vue 3 the page/file parameter inside the map closure will be reactive. So assigning new values will directly mutate the original object. Which is problematic in this case https://github.com/getkirby/kirby/compare/v5/develop...v5/refactor/nonmutating-modelssection-items-computed?expand=1#diff-97e5d0547fc36db8267a17f7b8e71ce28763c11dcba313d445cef261fce2ebc0R25 where we add the status button to other buttons. When the object is reactive, this adds an additional status button to the list, each time the computed prop code runs. By refactoring the code this is avoided.
Ready?