Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: DRY $app property #6474

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Tests: DRY $app property #6474

merged 1 commit into from
Jun 12, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jun 8, 2024 •
edited
Loading

Description

Summary of changes

  • Moved $app property to main TestCase class to keep it DRY
  • Added type hint Kirby\Cms\App

Reasoning

Keep it DRY and consistently named.

Ready?

  • Tests and checks all pass

@distantnative distantnative self-assigned this Jun 8, 2024
@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label Jun 8, 2024
@distantnative distantnative added this to the 5.0.0-alpha.1 milestone Jun 8, 2024
@distantnative distantnative marked this pull request as ready for review June 8, 2024 20:40
@distantnative distantnative requested a review from a team June 8, 2024 20:40
bastianallgeier
bastianallgeier approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels really nice :)

@bastianallgeier bastianallgeier merged commit 2a7e1a8 into v5/develop Jun 12, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/refactor/unit-tests-app-prop branch June 12, 2024 08:00
lukasbestle added a commit that referenced this pull request Jun 12, 2024
@lukasbestle
Fix test failure
d5d1d39 
Introduced by merging #6474 and #6448 together
lukasbestle added a commit that referenced this pull request Jun 12, 2024
@lukasbestle
Fix test failures
ebb9242 
Introduced by merging #6474 and #6448 together
@lukasbestle lukasbestle mentioned this pull request Jun 12, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Milestone
5.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier