Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non existing file links #6453

Merged
merged 2 commits into from
May 23, 2024

Conversation

afbora
Copy link
Member

@afbora afbora commented May 20, 2024

This PR …

Fixes

Breaking changes

None

Docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label May 20, 2024
@afbora afbora requested a review from a team May 20, 2024 15:30
@afbora afbora self-assigned this May 20, 2024
src/Cms/Media.php Outdated Show resolved Hide resolved
@afbora
Copy link
Member Author

afbora commented May 22, 2024

I'll squash commits if it's OK.

@afbora afbora requested review from a team, bastianallgeier and lukasbestle May 22, 2024 08:15
@afbora afbora force-pushed the fix/6446-non-existing-file-links branch from 5322979 to c7806f6 Compare May 22, 2024 14:51
@afbora afbora added this to the 4.3.0 milestone May 22, 2024
src/Cms/Media.php Outdated Show resolved Hide resolved
@distantnative distantnative merged commit e1bb532 into develop-minor May 23, 2024
12 checks passed
@distantnative distantnative deleted the fix/6446-non-existing-file-links branch May 23, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non existing files throw error 500: the thumbnail configuration could not be found
4 participants