Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning in router #6369

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Fix deprecation warning in router #6369

merged 3 commits into from
Apr 10, 2024

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Mar 25, 2024 •
edited
Loading

This PR …

Fixes

For review team

  • Add changes & docs to release notes draft in Notion

@bastianallgeier bastianallgeier added this to the 4.2.0 milestone Mar 25, 2024
@bastianallgeier bastianallgeier changed the base branch from main to develop-minor March 25, 2024 14:09
@bastianallgeier bastianallgeier requested a review from a team March 25, 2024 14:09
@distantnative distantnative linked an issue Mar 25, 2024 that may be closed by this pull request
Deprecation Warning: urldecode() #5895
Closed
@lukasbestle
Copy link
Member

Shouldn't we rather trim off additional slashes at the beginning to make routing work? Something along the lines of '/' . ltrim($path, '/').

@bastianallgeier
Copy link
Member Author

@lukasbestle I committed another try with the full-url trick. I think this should be more stable.

@bastianallgeier bastianallgeier modified the milestones: 4.2.0, 4.2.x Mar 27, 2024
lukasbestle
lukasbestle previously approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Added a comment so we later remember what it does and why.

@distantnative distantnative modified the milestones: 4.2.x, 4.2.1 Apr 1, 2024
@bastianallgeier bastianallgeier changed the base branch from develop-minor to develop-patch April 10, 2024 10:58
@bastianallgeier bastianallgeier dismissed lukasbestle’s stale review April 10, 2024 10:58

The base branch was changed.

@bastianallgeier bastianallgeier merged commit 6fb59f0 into develop-patch Apr 10, 2024
12 checks passed
@bastianallgeier bastianallgeier deleted the fix/5895-deprecation-in-router branch April 10, 2024 10:58
@distantnative distantnative modified the milestones: 4.2.1, 4.3.0 Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasbestle lukasbestle lukasbestle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Deprecation Warning: urldecode()
3 participants
@bastianallgeier @lukasbestle @distantnative