Apply code reviews

getkirby · Jul 22, 2024 · 178fa70 · 178fa70
1 parent 54deeb0
commit 178fa70
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/Cms/LanguageTranslations.php b/src/Cms/LanguageTranslations.php
@@ -19,14 +19,12 @@
  */
 class LanguageTranslations
 {
-	protected App   $kirby;
 	protected array $data;
 
 	public function __construct(
 		protected Language $language,
 		self|array $translations = []
 	) {
-		$this->kirby = App::instance();
 		$this->setTranslations($translations);
 	}
 
@@ -62,8 +60,9 @@ public function load(array $default = []): array
 	 */
 	public function save(array $translations = []): static
 	{
+		$this->setTranslations($translations);
+
 		if ($root = $this->root()) {
-			$this->data = $translations;
 			Data::write($root, $translations);
 		}
 
@@ -77,7 +76,7 @@ public function root(): string|null
 	{
 		$kirby = App::instance();
 		$root  = $kirby->root('translations');
-		$file  = $root . '/' . $this->language->code() . '.php';
+		$file  = ($root ?? '') . '/' . $this->language->code() . '.php';
 
 		if (
 			$root !== null &&