Add until modifier to within pattern
#441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mentatbot[bot]](https://avatars.githubusercontent.com/in/837875?s=60&v=4){kind=small}
This update introduces an `until` modifier to the `within` pattern, similar to the `contains ... until` functionality. The `until` modifier allows for more flexible pattern matching by specifying an endpoint condition. Changes include: - Updated `WithinCompiler` to handle the `until` modifier. - Modified `Within` struct to include an optional `until` pattern. - Adjusted the `Matcher` implementation for `Within` to break the matching process when the `until` condition is met.
This commit addresses the CI failure caused by the missing release type in the pull request title. The title has been updated to include the appropriate release type prefix. Changes include: - Updated the pull request title to follow the conventional commits format. - Ensured the CI workflow recognizes the release type for proper processing.
This commit addresses the CI failure by modifying the `from_node_binding` method to accept a reference to the node instead of taking ownership. This change resolves the move error encountered during the compilation of the `grit-pattern-matcher` crate. Changes include: - Updated `from_node_binding` method in `ResolvedPattern` trait to accept a reference to the node. - Adjusted calls to `from_node_binding` in `within.rs` to pass a reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces an
untilmodifier to thewithinpattern, similar to thecontains ... untilfunctionality. Theuntilmodifier allows for more flexible pattern matching by specifying an endpoint condition.Changes include:
WithinCompilerto handle theuntilmodifier.Withinstruct to include an optionaluntilpattern.Matcherimplementation forWithinto break the matching process when theuntilcondition is met.Closes #436
Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!