Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hCaptcha support #562

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

aleclerc7
Copy link

This will add hCaptcha support.

  • The user only needs to select the provider: reCaptcha or hCaptcha.

👉 PHP code on server side could (should) be optimized.

Tested to be working.

  • reCaptcha (Google) works as before and is the default behaviour.
  • hCaptcha has been tested for v2-checkbox and works.
  • No error cases were tested for hCaptcha, so unknown behaviour in such cases.

Fixes #423.
Replaces #515.

Kind regards.

This will add hCaptcha support.

- The user only needs to select the provider, set the keys.
- This is a drop-in replacement of reCaptcha.

PHP code on server side could be optimized.

Tested to be working. No error cases were tested.
@ghost
Copy link

ghost commented Aug 25, 2022

It would be nice if you take a look at this Pull Request, because it's a very important feature for people like me who want alternatives that are more ethical and respectful of our users than Google.

@@ -189,10 +197,8 @@ form:
recaptcha.site_key:
type: text
label: PLUGIN_FORM.RECAPTCHA_SITE_KEY
help: PLUGIN_FORM.RECAPTCHA_SITE_KEY_HELP

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these does not seem right to me.

Copy link

@robhuijben robhuijben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although hCaptcha is working with this drop-in replacement, there are some additions that seem to make the captcha section less understandable. For instance, hCaptcha is not using the words 'site key' and 'secret key' as a combination, but use 'site key' and 'account key'. Therefore I think it would be better to split the hCaptcha implementation from the original reCaptcha part and provide it to the end user as a standalone section in the Forms plugin configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hcaptcha support
2 participants