Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove security and privacy issue Gravatar #544 #545

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Dec 27, 2021

Fixes: Remove security and privacy issue Gravatar #544

Change: Replaces Gravatar image with an user icon.

@rhukster
Copy link
Member

rhukster commented Dec 27, 2021

This changes the existing behavior. If your would like this functionality it should be an optional setting via the admin plugin.

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Dec 27, 2021

Then the functionality should not be hardcoded in the form plugin.

The functionality should just be coded in one place. Currently I found it in 3 places: core, admin and forms...

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Jan 6, 2022

@rhukster I reviewed my PR. So far this PR does not change a functionality. The reason is, that function getAvatarUrl() from core always returns an url with gravatar as default. So avatar is always true and the else part is never executed.
If my open PR getgrav/grav#3501 on core is merged this PR would have an impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants