Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color and label prop to swirl-separator #885

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

joseabernardes
Copy link
Collaborator

Summary

Review Checklist

General

  • Changeset added
  • The submitted code is organized and formatted according to our 💅 Style Guide.
    • The code is formatted with Prettier.
    • There are no linting errors.

For new or updated components

https://swirl-storybook.flip-app.dev/?path=/docs/contributions-merge-publish--page

  • The changes do not contain any breaking changes.
  • The changes do not introduce new components that don't belong in the library (e.g. non-reusable components, highly specialized components, components including business logic)
  • The component documentation is updated.
  • The changes meet the 🤖 testing requirements.
    • New features are tested.
    • In case of bug fixes, regression tests have been added.
    • All tests are 🟢.
  • The changes meet the 🧏‍♀️ accessibility requirements.
    • WCAG 2.1 Level A and Level AA requirements are met.
    • The Storybook a11y addon shows no errors.
    • The changes have been tested with a screen reader.
    • Keyboard controls have been tested, if applicable.
    • Components implementing form controls (inputs, buttons, selects, etc.) do not use Shadow DOM, and instead use Stencil's scoping mechanism
  • The changes use our 🌈 theming concept.
    • Design tokens have been used where appropriate.
    • The component has been visually checked in combination with the "Light" and "Dark" theme.
  • The changes meet our 🌍 internationalization requirements.
    • No static text is used.
    • The component doesn't break with longer texts or different text wrappings.
    • Number, currency and date values can be formatted appropriately.
  • The changes work in all supported browsers and viewports. See 📱 Responsive Design

@joseabernardes joseabernardes requested a review from Sqrrl as a code owner December 9, 2024 11:36
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
getflipdev ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 3:37pm
staginggetflipdev ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 3:37pm

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-885.westeurope.3.azurestaticapps.net

Copy link

@nunofaria11 nunofaria11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left a minor (non-blocking) suggestion regarding label sizing.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-885.westeurope.3.azurestaticapps.net

@joseabernardes joseabernardes merged commit f329ddd into main Dec 10, 2024
8 of 9 checks passed
@joseabernardes joseabernardes deleted the hightlight-separator branch December 10, 2024 08:50
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants