Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#445 replace heading balancing with native css text wrap #451

Merged
merged 1 commit into from
Nov 13, 2023
Merged

#445 replace heading balancing with native css text wrap #451

merged 1 commit into from
Nov 13, 2023

Conversation

Sqrrl
Copy link
Collaborator

@Sqrrl Sqrrl commented Nov 13, 2023

Summary

Review Checklist

General

  • Changeset added
  • The submitted code is organized and formatted according to our 💅 Style Guide.
    • The code is formatted with Prettier.
    • There are no linting errors.

For new or updated components

https://swirl-storybook.flip-app.dev/?path=/docs/contributions-merge-publish--page

  • The changes do not contain any breaking changes.
  • The changes do not introduce new components that don't belong in the library (e.g. non-reusable components, highly specialized components, components including business logic)
  • The component documentation is updated.
  • The changes meet the 🤖 testing requirements.
    • New features are tested.
    • In case of bug fixes, regression tests have been added.
    • All tests are 🟢.
  • The changes meet the 🧏‍♀️ accessibility requirements.
    • WCAG 2.1 Level A and Level AA requirements are met.
    • The Storybook a11y addon shows no errors.
    • The changes have been tested with a screen reader.
    • Keyboard controls have been tested, if applicable.
    • Components implementing form controls (inputs, buttons, selects, etc.) do not use Shadow DOM, and instead use Stencil's scoping mechanism
  • The changes use our 🌈 theming concept.
    • Design tokens have been used where appropriate.
    • The component has been visually checked in combination with the "Light" and "Dark" theme.
  • The changes meet our 🌍 internationalization requirements.
    • No static text is used.
    • The component doesn't break with longer texts or different text wrappings.
    • Number, currency and date values can be formatted appropriately.
  • The changes work in all supported browsers and viewports. See 📱 Responsive Design

@Sqrrl Sqrrl requested a review from webspaceadam as a code owner November 13, 2023 09:57
@Sqrrl Sqrrl linked an issue Nov 13, 2023 that may be closed by this pull request
Heading breaks upon line break #445
Closed
@vercel Vercel
Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
getflipdev ⬜️ Ignored (Inspect) Nov 13, 2023 9:57am
staginggetflipdev ⬜️ Ignored (Inspect) Nov 13, 2023 9:57am

@Sqrrl Sqrrl mentioned this pull request Nov 13, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-451.westeurope.3.azurestaticapps.net

@Sqrrl Sqrrl merged commit 8d4ce24 into main Nov 13, 2023
7 checks passed
@Sqrrl Sqrrl deleted the 445-heading-breaks-upon-line-break branch November 13, 2023 13:24
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webspaceadam webspaceadam webspaceadam approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heading breaks upon line break
2 participants
@Sqrrl @webspaceadam