Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-17219 web component accordion #401

Merged
merged 4 commits into from
Oct 5, 2023
Merged

APP-17219 web component accordion #401

merged 4 commits into from
Oct 5, 2023

Conversation

Sqrrl
Copy link
Collaborator

@Sqrrl Sqrrl commented Oct 5, 2023 •
edited
Loading

Summary

Review Checklist

General

  • Changeset added
  • The submitted code is organized and formatted according to our 💅 Style Guide.
    • The code is formatted with Prettier.
    • There are no linting errors.

For new or updated components

https://swirl-storybook.flip-app.dev/?path=/docs/contributions-merge-publish--page

  • The changes do not contain any breaking changes.
  • The changes do not introduce new components that don't belong in the library (e.g. non-reusable components, highly specialized components, components including business logic)
  • The component documentation is updated.
  • The changes meet the 🤖 testing requirements.
    • New features are tested.
    • In case of bug fixes, regression tests have been added.
    • All tests are 🟢.
  • The changes meet the 🧏‍♀️ accessibility requirements.
    • WCAG 2.1 Level A and Level AA requirements are met.
    • The Storybook a11y addon shows no errors.
    • The changes have been tested with a screen reader.
    • Keyboard controls have been tested, if applicable.
    • Components implementing form controls (inputs, buttons, selects, etc.) do not use Shadow DOM, and instead use Stencil's scoping mechanism
  • The changes use our 🌈 theming concept.
    • Design tokens have been used where appropriate.
    • The component has been visually checked in combination with the "Light" and "Dark" theme.
  • The changes meet our 🌍 internationalization requirements.
    • No static text is used.
    • The component doesn't break with longer texts or different text wrappings.
    • Number, currency and date values can be formatted appropriately.
  • The changes work in all supported browsers and viewports. See 📱 Responsive Design

@Sqrrl Sqrrl requested a review from webspaceadam as a code owner October 5, 2023 09:02
@vercel
Copy link

vercel bot commented Oct 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
getflipdev ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2023 11:46am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-401.westeurope.3.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-401.westeurope.3.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-401.westeurope.3.azurestaticapps.net

@Sqrrl Sqrrl merged commit 4d80367 into main Oct 5, 2023
7 checks passed
@Sqrrl Sqrrl deleted the APP-17219-web-component-accordion branch October 5, 2023 11:57
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webspaceadam webspaceadam Awaiting requested review from webspaceadam

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sqrrl