fix(components): fix SwirlFileUploader label id

getflip · Oct 5, 2023 · 4837a48 · 4837a48
1 parent c0bbfd7
commit 4837a48
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/short-poets-share.md b/.changeset/short-poets-share.md
@@ -0,0 +1,7 @@
+---
+"@getflip/swirl-components": patch
+"@getflip/swirl-components-angular": patch
+"@getflip/swirl-components-react": patch
+---
+
+Fix incorrect swirl-file-uploader label id
diff --git a/packages/swirl-components/src/components/swirl-file-uploader/swirl-file-uploader.spec.tsx b/packages/swirl-components/src/components/swirl-file-uploader/swirl-file-uploader.spec.tsx
@@ -21,7 +21,7 @@ describe("swirl-file-uploader", () => {
     expect(page.root).toEqualHtml(`
       <swirl-file-uploader accept="image/*" cta-label="CTA Label" description="Only image files are allowed." drag-drop-label="DragDropLabel" input-id="file-upload" input-name="file-upload" label="Label" multiple="true">
         <div class="file-uploader file-uploader--show-dropzone">
-          <label class="file-uploader__label" htmlfor="file-upload" id="undefined-label">
+          <label class="file-uploader__label" htmlfor="file-upload" id="file-upload-label">
             Label
           </label>
           <span class="file-uploader__description" id="file-upload-description">

diff --git a/packages/swirl-components/src/components/swirl-file-uploader/swirl-file-uploader.tsx b/packages/swirl-components/src/components/swirl-file-uploader/swirl-file-uploader.tsx
@@ -78,7 +78,7 @@ export class SwirlFileUploader implements SwirlFormInput<FileList> {
           <label
             class="file-uploader__label"
             htmlFor={this.inputId}
-            id={`${this.inputEl}-label`}
+            id={`${this.inputId}-label`}
           >
             {this.label}
           </label>