Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update create-react-app example in Readme #59

Merged
merged 3 commits into from
Apr 23, 2024
Merged

chore: update create-react-app example in Readme #59

merged 3 commits into from
Apr 23, 2024

Conversation

pvditto
Copy link
Contributor

@pvditto pvditto commented Apr 18, 2024

I tried following the example and ran into some issues. Here, I have updated the Readme to fix these.

  • add correct imports
  • fix syntax
  • add reference to more information on specifying a web assembly module
  • convert the example to use onlinePlayground which is preferred
  • updates React syntax
  • turns the example into a basic tasks app

@pvditto pvditto marked this pull request as ready for review April 18, 2024 13:57
@pvditto pvditto self-assigned this Apr 18, 2024
@pvditto pvditto requested a review from jreyes33 April 18, 2024 13:57
@pvditto pvditto linked an issue Apr 18, 2024 that may be closed by this pull request
Problems following Readme for create-react-app #49
Closed
jreyes33
jreyes33 reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@jreyes33 jreyes33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! Again, just a small nit about the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
@pvditto pvditto changed the title Update create-react-app example in Readme chore: update create-react-app example in Readme Apr 22, 2024
@pvditto
Revert "Add changelog"
e59468b 
This reverts commit 5eba826.
@pvditto pvditto requested a review from jreyes33 April 22, 2024 10:21
jreyes33
jreyes33 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@jreyes33 jreyes33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pvditto pvditto merged commit 3406984 into master Apr 23, 2024
1 check passed
@pvditto pvditto deleted the pv/update-readme branch April 23, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreyes33 jreyes33 jreyes33 approved these changes

Assignees

@pvditto pvditto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems following Readme for create-react-app
2 participants
@pvditto @jreyes33