Make into a proper python package w/ standalone protocol definitions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix requirements.txt hook into hatch build backend. - Move requirements.txt to top-level dir. - Adjust paths to reflect new python project layout. - Add documentation on how to publish the package.
ajfabbri
force-pushed
the
af/package2
branch
4 times, most recently
from
c0336b9
to
1be9ece
Compare
Should fix imports so they work both from the source tree, and from the installed module (pip install)
Also: - Update usage help text for generate.py - Bump package version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue the work from #6, making this a python package that is ready to publish, and improving support for separate protocol definitions and generated assets:
generate.py --install-toolchaingenerate.pyreplace--docs-dirwith--output-dir. Now we have:--protocol-dir <Path with your version subdirs with Avro IDL files>--output-dir <Path to output generate schemas / code / docs to>python -m pip install interface_genNote: command for running
generate.pyhas changed: you need to run it as a module as shown in the updated instructions at interface_gen/README.md. This allows the import paths to work correctly both when running frompip installand from the source tree.