This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
feat: add ldk custom tlvs to metadata custom records #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
reviewed
Jun 14, 2024
| for _, tlv := range spontaneousPaymentKind.CustomTlvs { | ||
| customRecords[strconv.FormatUint(tlv.Type, 10)] = b64.StdEncoding.EncodeToString(tlv.Value) | ||
| } | ||
| metadata["custom_records"] = customRecords |
There was a problem hiding this comment.
wondering if we should put it in custom_records or on the root level?
in custom_records it's more clear but at the same time more technical?
There was a problem hiding this comment.
I think it should be under custom_records. It's already technical because all the keys are random numbers 😅
There was a problem hiding this comment.
how about we call it tlv_records - then it is more consistent with the pay_keysend nip?
|
@im-adithya can you do the same for LND - if the transaction in LND has custom records add those to the metadata field. |
Issue here: getAlby/hub#60 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables NWC apps that display transactions to show podcasting 2.0 details
See getAlby/lightning-browser-extension#3172 for how it is consumed.
Note: this is inconsistent with how the TLVs are passed in https://github.com/nostr-protocol/nips/blob/master/47.md#pay_keysend
In retrospect I think this should actually be changed to be
metadata.tlv_recordsand have the same format aspay_keysend